Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: supports providing TiFlash table information filtered by keyspace #55817

Merged
merged 2 commits into from
Sep 4, 2024
Merged

executor: supports providing TiFlash table information filtered by keyspace #55817

merged 2 commits into from
Sep 4, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Sep 3, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

What changed and how does it work?

Pick part of https://github.com/tidbcloud/tidb-cse/pull/1030

  1. supports providing table information filtered by keyspace
  2. hide internal information

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Lloyd-Pottiger
sw
1f8803a 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 3, 2024

Hi @Lloyd-Pottiger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.5308%. Comparing base (939c97f) to head (3a139bc).
Report is 20 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #55817         +/-   ##
=================================================
- Coverage   72.7926%   58.5308%   -14.2619%     
=================================================
  Files          1588       1753        +165     
  Lines        443469     640432     +196963     
=================================================
+ Hits         322813     374850      +52037     
- Misses       100782     240716     +139934     
- Partials      19874      24866       +4992
Flag Coverage Δ
integration 41.3498% <100.0000%> (?)
unit 73.4293% <100.0000%> (+1.5259%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.5253% <ø> (+1.5686%) ⬆️
parser ∅ <ø> (∅)
br 64.6145% <ø> (+19.1833%) ⬆️

@Lloyd-Pottiger
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Sep 3, 2024

@Lloyd-Pottiger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Lloyd-Pottiger
Copy link
Contributor Author

/cc @breezewish @JaySon-Huang @tangenta

@Lloyd-Pottiger
fix ut
3a139bc 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
Copy link
Contributor Author

/cc @zimulala

@ti-chi-bot ti-chi-bot bot requested a review from zimulala September 3, 2024 12:53
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-03 13:00:24.975731931 +0000 UTC m=+362949.493784859: ☑️ agreed by tangenta.
  • 2024-09-04 08:18:28.762759924 +0000 UTC m=+432433.280812849: ☑️ agreed by breezewish.

@Lloyd-Pottiger
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Sep 4, 2024

@Lloyd-Pottiger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiprow tiprow
Copy link

tiprow bot commented Sep 4, 2024

@Lloyd-Pottiger: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 3a139bc link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Lloyd-Pottiger
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Sep 4, 2024

@Lloyd-Pottiger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Lloyd-Pottiger
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Sep 4, 2024

@Lloyd-Pottiger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit a004bba into pingcap:master Sep 4, 2024
23 of 25 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-system-table branch September 5, 2024 02:02
@breezewish breezewish mentioned this pull request Sep 6, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@breezewish breezewish breezewish approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lloyd-Pottiger @breezewish @tangenta